Skip to content

Add wasm as SPMI target#122510

Merged
AndyAyersMS merged 3 commits intodotnet:mainfrom
AndyAyersMS:WasmSPMI
Dec 16, 2025
Merged

Add wasm as SPMI target#122510
AndyAyersMS merged 3 commits intodotnet:mainfrom
AndyAyersMS:WasmSPMI

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Dec 12, 2025

Allow passing -target wasm when using a Wasm cross-jit.

@AndyAyersMS
Add wasm as SPMI target
ccfc365 
Allow passing `-target wasm` when using a Wasm cross-jit.
Copilot AI review requested due to automatic review settings December 12, 2025 23:04
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 12, 2025
Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds WebAssembly (WASM) as a valid SPMI (Super PMI - a JIT testing tool) target architecture, enabling cross-compilation support for wasm/wasm32/wasm64 targets. The changes extend the existing architecture enumeration, command-line parsing, and target matching logic to recognize WebAssembly platforms.

Key changes:

  • Added WASM32 and WASM64 to the SPMI target architecture enumeration and classification functions
  • Extended command-line parsing to accept "wasm", "wasm32", and "wasm64" as valid target values
  • Updated architecture matching logic to support WASM32 (note: WASM64 support is incomplete)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/coreclr/tools/superpmi/superpmi-shared/spmiutil.h Adds WASM32 and WASM64 enum values and updates 32-bit/64-bit architecture helper functions
src/coreclr/tools/superpmi/superpmi-shared/spmiutil.cpp Adds TARGET_WASM32 and TARGET_WASM64 preprocessor conditionals for default architecture initialization
src/coreclr/tools/superpmi/superpmi/commandline.cpp Updates help text and command-line validation to accept wasm/wasm32/wasm64 as target values
src/coreclr/tools/superpmi/superpmi/superpmi.cpp Adds string-to-enum mapping for "wasm"/"wasm32" → WASM32 and "wasm64" → WASM64
src/coreclr/tools/superpmi/superpmi/jitinstance.cpp Refactors switch from IMAGE_FILE_MACHINE constants to CORINFO_ARCH constants and adds CORINFO_ARCH_WASM32 case

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Dec 12, 2025

@dotnet/jit-contrib PTAL

Also a bit of support for Wasm64.

Running (as jit) on a subset of codegen bring up tests:

>> superpmi.exe \clrjit_universal_wasm_x64.dll basic.mch -target wasm
Using jit(clrjit_universal_wasm_x64.dll) with input (basic.mch)
 indexCount=-1 ()
Jit startup took 7.340200ms
MISSING: Method context 1 failed to replay: SuperPMI assertion failed (missing map GetClassAlignmentRequirement): key 00007FFEA4B530E8
MISSING: Method context 2 failed to replay: SuperPMI assertion failed (missing map GetClassAlignmentRequirement): key 00007FFEA4B530E8
   1: JIT compiled BringUpTest_Add1:Add1(int):int [MinOpts, IL size=9, code size=13, hash=0xd655d0d8]
   2: JIT compiled BringUpTest_And1:And1(int):int [MinOpts, IL size=9, code size=13, hash=0x507a7698]
   3: JIT compiled BringUpTest_Args4:Args4(int,int,int,int):int [MinOpts, IL size=13, code size=22, hash=0x6912b5e7]
   4: JIT compiled BringUpTest_Args5:Args5(int,int,int,int,int):int [MinOpts, IL size=16, code size=26, hash=0xd5644518]
   5: JIT compiled BringUpTest_AsgAdd1:AsgAdd1(int):int [MinOpts, IL size=12, code size=17, hash=0x5f2e7fd8]
   6: JIT compiled BringUpTest_AsgAnd1:AsgAnd1(int):int [MinOpts, IL size=12, code size=17, hash=0x0cda2158]
   7: JIT compiled BringUpTest_AsgOr1:AsgOr1(int):int [MinOpts, IL size=13, code size=17, hash=0x224b6ff8]
   8: JIT compiled BringUpTest_AsgSub1:AsgSub1(int):int [MinOpts, IL size=12, code size=17, hash=0x9de99718]
   9: JIT compiled BringUpTest_AsgXor1:AsgXor1(int):int [MinOpts, IL size=13, code size=17, hash=0xa19d25d8]
...
Loaded 160  Jitted 160  FailedCompile 45 Excluded 0 Missing 2
Total time: 64.988700ms

Failures (not shown) are mainly for tests with calls/byrefs/casts/unordered compares.

adamperlin
adamperlin reviewed Dec 13, 2025
View reviewed changes
adamperlin
adamperlin reviewed Dec 13, 2025
View reviewed changes
@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Dec 13, 2025

Odd that CI skips superpmi runs for changes to superpmi sources. Probably need to adjust some triggers somewhere.

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Dec 13, 2025

/azp run runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 13, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

am11
am11 reviewed Dec 13, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Dec 13, 2025
Closed
adamperlin
adamperlin approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@adamperlin adamperlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@am11 am11 added the arch-wasm WebAssembly architecture label Dec 16, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 16, 2025

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS AndyAyersMS merged commit 35ccd52 into dotnet:main Dec 16, 2025
100 checks passed
This was referenced Jan 9, 2026
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@adamperlin adamperlin adamperlin approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMS AndyAyersMS

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyAyersMS @am11 @adamperlin